consolidate-backfill-transfers#372
Merged
Merged
Conversation
…o for FK integrity
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a database migration to ensure the SamplePtID column in the NMA_Chemistry_SampleInfo table is of type UUID before adding foreign key constraints. The change prevents potential type mismatch errors when creating relationships between tables.
Changes:
- Added type conversion logic for
SamplePtIDcolumn to UUID type if it exists and is not already UUID - Positioned the type conversion before the existing unique constraint check
Comment on lines
+53
to
+60
| sample_pt_col = next( | ||
| ( | ||
| col | ||
| for col in inspector.get_columns("NMA_Chemistry_SampleInfo") | ||
| if col["name"] == "SamplePtID" | ||
| ), | ||
| None, | ||
| ) |
There was a problem hiding this comment.
The get_columns() call iterates through all columns to find one specific column. Consider using a more direct approach by checking if the column exists first, then retrieving its type separately, to avoid unnecessary iteration through all columns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem / context:
How
Implementation summary - the following was changed / added / removed:
Notes
Any special considerations, workarounds, or follow-up work to note?